Thank you. 

I'm not sure how this would break BC since this really only effects the creation of a new table.  If it does and you can point out in what regard I'm more then happy to dive in and try to fix.

On 7/24/07, Hans Lellelid <hans@velum.net> wrote:
I will grant that Kevin clearly knows more than I do about SERIAL use in
pgsql :)  I always just create the sequences separately.  If the patch
attached to the ticket ( http://propel.phpdb.org/trac/ticket/4) does not
break backwards compatibility or have other strange side-effects, then
I'm for adding this in.  If it does break BC, then we need at least to
make this a build option.

Hans

Cameron Brunner wrote:
> I'v read this a few times and my head hurts by the time i get to the
> end of the email. I'll try reading it again when i wake up, hopefully
> a clear head is more useful to understand what you are getting at.
>
> On 7/23/07, Kevin Barnard <kevin.barnard@gmail.com> wrote:
>> It does two things that currently are not done.  Both of which are
>> really useful if you modify the database outside of Propel methods.
>>
>> First it creates and entry in pg_depend system catalog which helps out
>> the DBA and any attempt to reverse engineer the DB.
>>
>> Secondly it ties the default column to the sequence.  This could be
>> done with an ALTER TABLE statement or by setting the default value for
>> the column in the CREATE TABLE statement.
>>
>> This is allows for more sane SQL creation scripts from the XML.  The
>> alternative which I am currently using is to create the schema by hand
>> the then use the id-method-parameter to specify the name.
>>
>> Does that make sense?
>>
>> There are a couple of things that can be cleaned up further to make
>> this patch more sane.  Namely moving table creation syntax into the DB
>> Platform object but that's a pretty big deal and more of a 2.0 type
>> issue.  I'm getting my feet wet at this point.
>>
>>
>> On 7/22/07, Cameron Brunner <cameron.brunner@gmail.com> wrote:
>> > Its early and my head hurts but i'm not seeing a point to this patch
>> > currently? Care to hit me in the face with a LART and try to explain
>> > what can't be done now that this patch manages to accomplish? Serial
>> > just creates an INT4 column with a default nextval(sequence), sets it
>> > not null and makes the sequence itself... how is that different from
>> > what we do now? We just do it by hand instead... did i miss something?
>> >
>> > On 7/23/07, Kevin Barnard < kevin.barnard@gmail.com> wrote:
>> > > It would be nice if my patch to ticket 4 could make it in.  This
>> would
>> > > really help when Propel moves into Symfony.  Very small patch.
>> > >
>> > > Thank you
>> > >
>> > > On 7/21/07, Cameron Brunner <cameron.brunner@gmail.com> wrote:
>> > > > Is the next beta (perhaps the point in time to turn into rc) on the
>> > > > 1st realistic to merge in your nested sets as well as hans to
>> finish
>> > > > the default work he was playing with? it will be long enough for
>> me to
>> > > > get debug fleshed out enough to be useful without bugs....
>> > > >
>> > > > did there end up a bug in time column handling as well or have
>> we not
>> > > > looked into it fully as yet?
>> > > >
>> > > > Any users out there that want something in before this release
>> or know
>> > > > of any bugs, hit us up and voice your say, the sooner the
>> better, i'm
>> > > > personally dying for 1.3 to go 'stable'
>> > > >
>> > > > On 7/22/07, David Zülke < dz@bitxtender.com> wrote:
>> > > > > I'd like to merge in my nested sets branch. Set me a deadline,
>> and I
>> > > > > shall comply! :)
>> > > > >
>> > > > >
>> > > > > David
>> > > > >
>> > > > >
>> > > > >
>> > > > > Am 21.07.2007 um 18:32 schrieb Cameron Brunner:
>> > > > >
>> > > > > > Is there anything major outstanding that needs to be
>> organized before
>> > > > > > we consider another beta? Personally id like to see some
>> form of the
>> > > > > > new debugging stuff go in (i'm cleaning up what i have
>> locally over
>> > > > > > the weekend, its somewhat better already), anything else?
>> and for that
>> > > > > > matter, has anything big changed? As far as i remember about
>> all thats
>> > > > > > happened is the instance pool global enable/disable and
>> something with
>> > > > > > datetime (but i think this was last version? or is it both?)
>> > > > > >
>> > > > > > --
>> > > > > > Cameron Brunner
>> > > > > >
>> > > > > > Want a better web browser?
>> > > > > > http://www.spreadfirefox.com/?q=affiliates&id=182780&t=1
>> > > > > >
>> > > > > >
>> ---------------------------------------------------------------------
>> > > > > > To unsubscribe, e-mail: dev-unsubscribe@propel.tigris.org
>> > > > > > For additional commands, e-mail: dev-help@propel.tigris.org
>> > > > > >
>> > > > > >
>> > > > >
>> > > > >
>> ---------------------------------------------------------------------
>> > > > > To unsubscribe, e-mail: dev-unsubscribe@propel.tigris.org
>> > > > > For additional commands, e-mail: dev-help@propel.tigris.org
>> > > > >
>> > > > >
>> > > >
>> > > >
>> > > > --
>> > > > Cameron Brunner
>> > > >
>> > > > Want a better web browser?
>> > > > http://www.spreadfirefox.com/?q=affiliates&id=182780&t=1
>> > > >
>> > >
>> > >
>> > > --
>> > > Kevin Barnard
>> > >
>> > > "Great Beauty, great strength, and great Riches,
>> > >  are really and truly of no great Use;
>> > >  a right Heart exceeds all." -- Benjamin Franklin
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: dev-unsubscribe@propel.tigris.org
>> > > For additional commands, e-mail: dev-help@propel.tigris.org
>> > >
>> > >
>> >
>> >
>> > --
>> > Cameron Brunner
>> >
>> > Want a better web browser?
>> > http://www.spreadfirefox.com/?q=affiliates&id=182780&t=1
>> >
>>
>>
>> --
>> Kevin Barnard
>>
>> "Great Beauty, great strength, and great Riches,
>>  are really and truly of no great Use;
>>  a right Heart exceeds all." -- Benjamin Franklin
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@propel.tigris.org
>> For additional commands, e-mail: dev-help@propel.tigris.org
>>
>>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@propel.tigris.org
For additional commands, e-mail: dev-help@propel.tigris.org




--
Kevin Barnard

"Great Beauty, great strength, and great Riches,
are really and truly of no great Use;
a right Heart exceeds all." -- Benjamin Franklin