Login | Register
My pages Projects Community openCollabNet

propel
Reply to message

* = Required fields
* Subject
* Body
Attachments
Send reply to
Topic
Author (directly in email)
Please type the letters in the image above.

Original message

Author hlellelid
Full name Hans Lellelid
Date 2008-05-06 09:48:07 PDT
Message Hi Ron,

Thank you! Yes, I think your implementation is correct; I read over the
ticket again and think that I did not fully understand it the first time.
This is apparently for a composite fkey, which your approach correctly
solves.

I will look over the ticket list, but I think that we should be able to
release an RC now or very soon.

Thanks again,
Hans

On Tue, 06 May 2008 17:51:25 +0200, Ron Rademaker
<r.rademaker@virt​ualbuilding.nl> wrote:
> Hi Hans,
>
> I just commited a fix for 606. At least it works for the unit test you
> added and those I added earlier today.
>
> Ron
>
> Hans Lellelid wrote:
>> Is that true ... ? Maybe; I thought we'd have to have them be separate
>> joins, but I haven't looked at this recently. I was assuming that we'd
>> need to introduce some aliasing to avoid collision in the generated
>> doSelectJoin*() method.
>>
>> Hans
>>
>> On Tue, 06 May 2008 15:47:08 +0200, Ron Rademaker
>> <r.rademaker@virt​ualbuilding.nl> wrote:
>>
>>> I just looked at that ticket. If I understand the problem correctly
>>> extending the addJoin API so it also accepts arrays for the first two
>>> arguments would solve it.
>>> Like:$criteria->​addJoin(LoggedOfferI​PPeer::MEMBER_ID,
>>> LoggedOfferPeer::MEMBER, Criteria::LEFT_JOIN);
>>>
>>> $criteria->addJo​in(LoggedOfferIPPeer​::OFFER_ID,
> LoggedOfferPeer::OFFERID,
>>> Criteria::LEFT_JOIN);
>>>
>>>
>>>
>>>
>>> Hans Lellelid wrote:
>>>
>>>> The one ticket I would really like to fix before RC is
>>>> http://propel.phpdb.​org/trac/ticket/606
>>>>
>>>> If you have a few spare minutes and want to look at that, I'd
> appreciate
>>>> it! -- Otherwise, that's first on my list to fix and I should be able
> to
>>>> finally get some non-housework done this weekend :)
>>>>
>>>> Hans
>>>>
>>>>
>>> --------------------​--------------------​--------------------​---------
>>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>>
>>
>>
>> --------------------​--------------------​--------------------​---------
>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>
>>
>>
>
>
> --------------------​--------------------​--------------------​---------
> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
> For additional commands, e-mail: dev-help at propel dot tigris dot org