Login | Register
My pages Projects Community openCollabNet

Reply to message

2020-03-13: This site is going to be decommissioned and shut down very soon. Please copy and archive any data you wish to keep ASAP

* = Required fields
* Subject
* Body
Send reply to
Author (directly in email)
Please type the letters in the image above.

Original message

Author Cameron Brunner <cameron.brunner@gmail.com>
Full name Cameron Brunner <cameron.brunner@gmail.com>
Date 2006-05-30 17:09:25 PDT
Message Just throwing my hat into the ring with a question here, will there be
any way to do identifier quoting on custom sql and what thoughts did
you have on identifier quoting with the new criteria setup? when i was
looking into it last it seemed the best method (most compatible) was
to pass around objects that had the info in it

Also as for spl_autoload, thats php5.1 not 5.0, you would need to bump
the version requirements for propel 1.3 if you wanted to commit those
so consider it carefully beforehand (im all for it being in 2.0 tho),
that said tho, this is quoting from

RIP: PHP_5_0

Sönke Rümpler wrote to internals@ wondering what the status of the PHP
5.0 series is these days. His assumption was that the branch is no
longer being updated; was he correct in believing that he should
upgrade to PHP 5.1.*?

Andi Gutmans confirmed that PHP 5.0.* development has now been
discontinued in favour of the PHP_5_1 branch, and advised Sönke to go
with the 5.1 series.

Short version: It's official.

so we can follow the official 'use 5.1' line that they are already
taking easily enough...


On 5/31/06, Hans Lellelid <hans at velum dot net> wrote:
> That is correct, yes. I didn't put up any examples of the Query yet,
> although you can see one in the ticket comments.
> Basically Query holds stuff that isn't strictly a "criteria". Of
> course, the line is a little grey when it comes to things like HAVING
> clause, which is a criteria ... but in those cases, the logic is that
> Query holds things that don't make sense nested like Criteria.
> I'm implementing the doInsert(), doUpdate(), and doDelete() now. When
> I'm done I may check in that code, but that will mean that old Criteria
> will cease to exist (or at least be usable) in trunk. That may be fine.
> I did some preliminary benchmarking and found the new Criteria system to
> be a bit quicker, but really there's not a lot of difference. The new
> system is more logically complex & involves many more method calls /
> object creation -- but then involves a lot less string parsing and code
> in general. These seem to even out in the end, making for only a few
> hundred microsecs improvement in the new implementation.
> (I haven't done any benchmarking of overall query performance in 1.2
> branch vs. trunk.)
> Hans
> P.S. I'd like to add the spl_autoload stuff in 2.0; I think you had some
> patches? We can also put this in a 1.3 if you like, but I have hopes
> that 2.0 is not going to be such a long development cycle as you think;
> I intend to use Propel 2.0 in an app I'm developing to be deployed by
> the end of the summer.
> Alan Pinstein wrote:
> > Nice... looking good.
> >
> > So I suppose that Criteria2 needs to go hand-in-hand with Query as well?
> > And that's where improved Join support, sorting, pagination, etc. will go?
> >
> > Alan
> >
> > On May 30, 2006, at 9:24 AM, Hans Lellelid wrote:
> >
> >> Hi Alan,
> >>
> >> I added some more examples to the wiki page.
> >>
> >> -H
> >>
> >> Alan Pinstein wrote:
> >>> Thanks for kicking this off.
> >>>
> >>> I posted something about a year ago (I can't believe I've been using
> >>> Propel for a year!) and I think most of the comments are still relevant:
> >>>
> >>> http://propel.tigris​.org/servlets/ReadMs​g?list=dev&msgNo​=609
> >>>
> >>> You've got a good start, but as you've mentioned, Criteria is currently
> >>> good at simple things but not a complex ones. Yet your examples on the
> >>> planning page are still relatively simply queries.
> >>>
> >>> I think we should think about the interface for the more complicated
> >>> parts as well:
> >>>
> >>> 1) Joining and table aliasing
> >>> 2) Sorting and pagination
> >>>
> >>> Can you explain the Query* classes more?
> >>>
> >>> I'd be happy to contribute time to flushing out design over the next few
> >>> weeks.
> >>>
> >>> Thanks!
> >>>
> >>> Alan
> >>>
> >>> On May 26, 2006, at 2:37 PM, Hans Lellelid wrote:
> >>>
> >>>> Hi -
> >>>>
> >>>> I put together a rough proposal/strategy for a new Criteria API on the
> >>>> wiki page.
> >>>>
> >>>> http://propel.phpdb.​org/trac/wiki/Develo​pment/Criteria
> >>>>
> >>>> The implementation is still only very loosely conceptual and it doesn't
> >>>> address all the functionality of the current system yet. It does,
> >>>> however, provide a more consistent & somewhat more intuitive system
> >>>> (both to use & to develop, in my opinion). The design is based loosely
> >>>> on the Hibernate Criteria API and the way that the logical expressions
> >>>> are handled by Phing's Condition system.
> >>>>
> >>>> I think it's a good starting point, and would be interested in any
> >>>> comments at this point.
> >>>>
> >>>> Hans