Login | Register
My pages Projects Community openCollabNet

propel
Reply to message

* = Required fields
* Subject
* Body
Attachments
Send reply to
Topic
Author (directly in email)
Please type the letters in the image above.

Original message

Author hlellelid
Full name Hans Lellelid
Date 2006-10-01 06:18:15 PDT
Message I have committed a modified version of this patch to 1.3, which we can
port to 2.0. It does not modify the PDO method signatures; it simply
allows nested transactions to be invoked without throwing an exception
-- or doing anything (the same functionality of the Transaction class).

Hans

Cameron Brunner wrote:
> What was the verdict about doing this in 2.0? Have you got something
> ready or should i commit what i have done or ?
>
>
> Cameron
>
> On 9/23/06, Hans Lellelid <hans at velum dot net> wrote:
>> Ok, well, I wasn't planning on changing anything about the behavior of
>> the PDO API except the fact that it throws an exception when you
>> beginTransaction() within another transaction. Or provide a
>> isInTransaction() method or something ...
>>
>> Hans
>>
>> Cameron Brunner wrote:
>> > I was trying to avoid altering the default pdo functionality, i just
>> > wanted to add what we needed for propel so when users used the
>> > connection directly it was 'as normal'...
>> >
>> >
>> > Cameron
>> >
>> > On 9/23/06, Hans Lellelid <hans at velum dot net> wrote:
>> >> I spend some more time looking at this & at PDO. I'm going to
>> commit a
>> >> slightly modified version of this to 1.3 branch (and later, to
>> trunk) --
>> >> so that API matches default PDO as possible.
>> >>
>> >> Thanks!
>> >>
>> >> Hans
>> >>
>> >> Hans Lellelid wrote:
>> >> > Hi Cameron,
>> >> >
>> >> > I just had an opportunity to look at this patch. I hadn't thought
>> >> about
>> >> > simply extending the PDO class. Were the
>> begin()/rollback()/commit()
>> >> > methods final (i.e. is that why you created txnBegin(), etc.)?
>> >> >
>> >> > I'd rather use an API that will allow us to revert to using the
>> >> default
>> >> > PDO driver, once its transaction support is improved.
>> >> >
>> >> > Hans
>> >> >
>> >> > Cameron Brunner wrote:
>> >> >
>> >> >> This needs a beating before it gets commited however i extended
>> PDO
>> >> >> and setup a transaction wrapper in it and altered the
>> generators to
>> >> >> use it. Anyone care to try it out and let me know how it goes for
>> >> >> them? Also does anyone have any objections to a patch along these
>> >> >> lines? I have it active on my sites and it seems fine...
>> >> >>
>> >> >>
>> >> >> Cameron
>
> --------------------​--------------------​--------------------​---------
> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
> For additional commands, e-mail: dev-help at propel dot tigris dot org
>