Login | Register
My pages Projects Community openCollabNet

propel
Reply to message

* = Required fields
* Subject
* Body
Attachments
Send reply to
Topic
Author (directly in email)
Please type the letters in the image above.

Original message

Author hlellelid
Full name Hans Lellelid
Date 2006-12-25 04:57:26 PST
Message Hi Eric,

Eric Fredj wrote:
> <snip>
>
> Hans, sorry for the way I provide patch, it is a svn diff between
> current branch and my modified one ;-)
> In fact, the patch brings some new file (Builder, Iterator) and require
> some modification on the core to integrate new builder calls, schema
> reworking to read some added attributes.
> How do you advise me to commit my patch ? I can commit in several times:
> new files (1), builder integration (2), schema addition (3), and then
> existing phing task update (4).
> Would it be ok for you ?

There's no problem with providing a patch like that; it's what I was
expecting. As for how you commit it, you can commit in one commit,
that's fine. What I was saying earlier was just that it would be good
to indicate in the source code (e.g. if you are modifying methods that
already existed in the base classes before) which code is specific to
the nestedset. Looking more at your design, though, it looks like it
will be fairly clear.

Thanks again! -- and merry christmas.

Hans