Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [propel-dev] Propel event handler

propel
Discussion topic

Back to topic list

Re: [propel-dev] Propel event handler

Reply

Author Ron Rademaker <r dot rademaker at virtualbuilding dot nl>
Full name Ron Rademaker <r dot rademaker at virtualbuilding dot nl>
Date 2008-05-06 06:50:42 PDT
Message Ok, really nice that CTRL+enter in thunderbird sends mail :)

Let's try again:

I just looked at that ticket. If I understand the problem correctly
extending the addJoin API so it also accepts arrays for the first two
arguments would solve it.
Like:

$criteria->addJo​in(LoggedOfferIPPeer​::MEMBER_ID, LoggedOfferPeer::MEMBER, Criteria::LEFT_JOIN);
$criteria->addJo​in(LoggedOfferIPPeer​::OFFER_ID, LoggedOfferPeer::OFFERID, Criteria::LEFT_JOIN);

becomes:

$criteria->addJo​in(array(LoggedOffer​IPPeer::MEMBER_ID, LoggedOfferIPPeer::OFFER_ID), array(LoggedOfferPeer::MEMBER, LoggedOfferPeer::OFFERID), Criteria::LEFT_JOIN);

Which would result in SQL like:

SELECT offer_ip_log.MEMBER_ID, offer_ip_log.OFFER_ID,
       offer_ip_log.IP, offer_ip_log.TIME, offer_ip_log.EXPIRED
  FROM `offer_ip_log`
  LEFT JOIN offerhistory ON (offer_ip_log.MEMBER​_ID=offerhistory.MEM​BER and offer_ip_log.OFFER_I​D=offerhistory.OFFER​ID)


Of course the old API will have to keep working as well.

Is this right? I'll take a look at implementing this, but I don't expect any problems.

Ron

Hans Lellelid wrote:
> The one ticket I would really like to fix before RC is
> http://propel.phpdb.​org/trac/ticket/606
>
> If you have a few spare minutes and want to look at that, I'd appreciate
> it! -- Otherwise, that's first on my list to fix and I should be able to
> finally get some non-housework done this weekend :)
>
> Hans
>

« Previous message in topic | 1 of 1 | Next message in topic »

Messages

Show all messages in topic

Re: [propel-dev] Propel event handler Ron Rademaker <r dot rademaker at virtualbuilding dot nl> Ron Rademaker <r dot rademaker at virtualbuilding dot nl> 2008-05-06 06:50:42 PDT
Messages per page: