Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [propel-dev] Re: News about NestedSet support in Propel ?

propel
Discussion topic

Back to topic list

Re: [propel-dev] Re: News about NestedSet support in Propel ?

Reply

Author hlellelid
Full name Hans Lellelid
Date 2006-12-25 04:57:26 PST
Message Hi Eric,

Eric Fredj wrote:
> <snip>
>
> Hans, sorry for the way I provide patch, it is a svn diff between
> current branch and my modified one ;-)
> In fact, the patch brings some new file (Builder, Iterator) and require
> some modification on the core to integrate new builder calls, schema
> reworking to read some added attributes.
> How do you advise me to commit my patch ? I can commit in several times:
> new files (1), builder integration (2), schema addition (3), and then
> existing phing task update (4).
> Would it be ok for you ?

There's no problem with providing a patch like that; it's what I was
expecting. As for how you commit it, you can commit in one commit,
that's fine. What I was saying earlier was just that it would be good
to indicate in the source code (e.g. if you are modifying methods that
already existed in the base classes before) which code is specific to
the nestedset. Looking more at your design, though, it looks like it
will be fairly clear.

Thanks again! -- and merry christmas.

Hans

« Previous message in topic | 17 of 20 | Next message in topic »

Messages

Show all messages in topic

News about NestedSet support in Propel ? Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2006-12-17 04:35:07 PST
     Re: News about NestedSet support in Propel ? Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2006-12-18 04:39:14 PST
         Re: [propel-dev] Re: News about NestedSet support in Propel ? hlellelid Hans Lellelid 2006-12-18 06:20:10 PST
             Re: [propel-dev] Re: News about NestedSet support in Propel ? hlellelid Hans Lellelid 2006-12-18 06:23:03 PST
                 RE: [propel-dev] Re: News about NestedSet support in Propel ? Soenke Ruempler - NorthClick <soenke dot ruempler at northclick dot de> Soenke Ruempler - NorthClick <soenke dot ruempler at northclick dot de> 2006-12-18 06:29:39 PST
                     Re: [propel-dev] trac/mod_python memory (was Re: News about NestedSet support in Propel ?) hlellelid Hans Lellelid 2006-12-18 06:29:49 PST
                         Re: [propel-dev] trac/mod_python memory (was Re: News about NestedSet support in Propel ?) Alan Pinstein <apinstein at mac dot com> Alan Pinstein <apinstein at mac dot com> 2006-12-18 07:45:57 PST
             Re: [propel-dev] Re: News about NestedSet support in Propel ? Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2006-12-18 12:09:53 PST
                 Re: [propel-dev] Re: News about NestedSet support in Propel ? Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2006-12-18 12:10:50 PST
                     Re: [propel-dev] Re: News about NestedSet support in Propel ? hlellelid Hans Lellelid 2006-12-18 12:11:32 PST
                         Re: [propel-dev] Re: News about NestedSet support in Propel ? Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2006-12-18 12:26:43 PST
                             Re: [propel-dev] Re: News about NestedSet support in Propel ? Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2006-12-24 02:52:40 PST
                                 Re: [propel-dev] Re: News about NestedSet support in Propel ? Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2006-12-24 03:34:48 PST
                                     Re: [propel-dev] Re: News about NestedSet support in Propel ? hlellelid Hans Lellelid 2006-12-24 05:37:01 PST
                                         Re: [propel-dev] Re: News about NestedSet support in Propel ? hlellelid Hans Lellelid 2006-12-24 09:30:04 PST
                                             Re: [propel-dev] Re: News about NestedSet support in Propel ? Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2006-12-25 03:40:17 PST
                                                 Re: [propel-dev] Re: News about NestedSet support in Propel ? hlellelid Hans Lellelid 2006-12-25 04:57:26 PST
                                 Re: [propel-dev] Re: News about NestedSet support in Propel ? Thomas Rabaix <thomas at rabaix dot net> Thomas Rabaix <thomas at rabaix dot net> 2006-12-24 06:17:51 PST
                                     Re: [propel-dev] Re: News about NestedSet support in Propel ? Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2006-12-27 14:46:50 PST
                                         Re: [propel-dev] Re: News about NestedSet support in Propel ? Thomas Rabaix <thomas at rabaix dot net> Thomas Rabaix <thomas at rabaix dot net> 2006-12-28 07:31:08 PST
Messages per page: