Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached)

propel
Discussion topic

Back to topic list

Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached)

Reply

Author hlellelid
Full name Hans Lellelid
Date 2007-10-23 07:16:37 PDT
Message Oh, ok. Sounds good.

We do have some nested set documentation on the wiki. If the new
classes change the way that stuff works, we should update it; otherwise,
I think an email with the changes -- for those using the nested set
stuff -- would be plenty.

Hans

David Zülke wrote:
> 'twas just general nested set improvements and bug fixes :) yes, will
> compile a mail describing the changes.
>
>
> David
>
>
>
> Am 23.10.2007 um 16:10 schrieb Hans Lellelid:
>
>> I'm not sure what changes are in your branch exactly, so I'd just like
>> to ask for some documentation for the new features / changes in behavior
>> before we release.
>>
>> Merge at will, though! I'd like to get another beta out -- and an RC,
>> eventually.
>>
>> Hans
>>
>> David Zülke wrote:
>>> I'll see if that patch needs merging into my branch. Speaking of which,
>>> I'd like to merge it into the 1.3 branch ASAP. Objections, anyone?
>>>
>>>
>>> David
>>>
>>>
>>>
>>>
>>> Am 17.10.2007 um 11:25 schrieb Cameron Brunner:
>>>
>>>> Patch applied. Thank you very much for the bug report and patch!
>>>>
>>>> On 10/17/07, Felix Gilcher <propel at andersground dot net> wrote:
>>>>> Hi,
>>>>>
>>>>> trying to add this as a ticket results in a 'Potential Spam' error,
>>>>> so I'm sending this to the list. I wonder what part matches the
>>>>> filter ;)
>>>>>
>>>>> -----
>>>>>
>>>>> the generated BaseFooNestedSetPeer​::deleteNode() retrieves the node
>>>>> to delete and then calls delete() on it. However, it passes (false,
>>>>> $con) as parameter while Node::delete() only accepts $con and thus,
>>>>> the deletion fails.
>>>>>
>>>>> A patch to fix this issue is attached.
>>>>> ------
>>>>>
>>>>> regards
>>>>>
>>>>> felix
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Cameron Brunner
>>>>
>>>> Want a better web browser?
>>>> http://www.spreadfir​efox.com/?q=affiliat​es&id=182780​&t=1
>>>>
>>>> --------------------​--------------------​--------------------​---------
>>>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>>>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>>>
>>>>
>>>
>>> --------------------​--------------------​--------------------​---------
>>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>>
>>
>> --------------------​--------------------​--------------------​---------
>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>
>>
>
> --------------------​--------------------​--------------------​---------
> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
> For additional commands, e-mail: dev-help at propel dot tigris dot org
>

« Previous message in topic | 6 of 31 | Next message in topic »

Messages

Show all messages in topic

PHP5NestedSetPeerBuilder slightly broken (PATCH attached) Felix Gilcher <propel at andersground dot net> Felix Gilcher <propel at andersground dot net> 2007-10-17 01:38:33 PDT
     Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) Cameron Brunner <cameron dot brunner at gmail dot com> Cameron Brunner <cameron dot brunner at gmail dot com> 2007-10-17 02:25:32 PDT
         Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-23 07:09:31 PDT
             Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) hlellelid Hans Lellelid 2007-10-23 07:10:52 PDT
                 Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-23 07:14:55 PDT
                     Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) hlellelid Hans Lellelid 2007-10-23 07:16:37 PDT
                         Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-23 07:17:53 PDT
                             [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-25 18:41:29 PDT
                                 Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-25 18:46:37 PDT
                                     Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-26 05:06:55 PDT
                                         Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-27 19:42:26 PDT
                                             Re: [propel-dev] NestSet 1.3 branch merge hlellelid Hans Lellelid 2007-10-27 20:11:42 PDT
                                                 Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-27 20:37:26 PDT
                                             Re: [propel-dev] NestSet 1.3 branch merge Frank Stelzer <dev at bleedingmoon dot de> Frank Stelzer <dev at bleedingmoon dot de> 2007-10-28 00:29:48 PDT
                                                 Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-28 03:57:10 PDT
                                                     Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-28 04:33:50 PDT
                                                     Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-28 04:39:16 PDT
                                                         Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-30 05:44:48 PDT
                                                             Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-11-02 12:18:04 PDT
                                                                 Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-11-02 14:03:03 PDT
                                                                     Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-11-03 03:04:21 PDT
                                                                         Re: [propel-dev] NestSet 1.3 branch merge hlellelid Hans Lellelid 2007-11-03 08:36:24 PDT
                                                                             Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-11-03 08:49:03 PDT
                                                                                 Re: [propel-dev] NestSet 1.3 branch merge hlellelid Hans Lellelid 2007-11-03 08:50:24 PDT
                                                                         Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-11-03 09:00:40 PDT
Page: of 2 « Previous | Next »
Messages per page: