Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [propel-dev] NestSet 1.3 branch merge

propel
Discussion topic

Back to topic list

Re: [propel-dev] NestSet 1.3 branch merge

Reply

Author Eric Fredj <eofredj at gmail dot com>
Full name Eric Fredj <eofredj at gmail dot com>
Date 2007-10-28 04:33:50 PDT
Message Ok.
I will explain my strategy.
I branch 1.3/ to heltem/ and then I applied all
david-multi_nested_set_tables/ branch changes on heltem/ to make easy
the future. merge

However, I saw many things which were buggy so I fixed some of them.

About sfPropel .... Plugin API, they got our API and added some methods
which made sense to me (insertAsParentOf(), ..) , so I integrated them
and some of ours was not yet implemented or were unuseful so I removed them.
And I added a parent attribute which made sense to me to simplify some
of our methods.

Moreover, I cleaned most of modifiers (static, public, etc.)

If you make a diff between yours and mine, I think changes are really
light and most of them are about 1.3 merge ....

I think the task now is to merge heltem/ and 1.3
Here is attached the patch for that.

My goal was really to make your merge task easy, David.

David Zülke a écrit :
> Okay... but I don't think we should start changing things just so it
> fits symfony more nicely. I don't remember changing method names in my
> branch, and we should keep it like that.
>
>
> David

« Previous message in topic | 16 of 31 | Next message in topic »

Messages

Show all messages in topic

PHP5NestedSetPeerBuilder slightly broken (PATCH attached) Felix Gilcher <propel at andersground dot net> Felix Gilcher <propel at andersground dot net> 2007-10-17 01:38:33 PDT
     Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) Cameron Brunner <cameron dot brunner at gmail dot com> Cameron Brunner <cameron dot brunner at gmail dot com> 2007-10-17 02:25:32 PDT
         Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-23 07:09:31 PDT
             Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) hlellelid Hans Lellelid 2007-10-23 07:10:52 PDT
                 Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-23 07:14:55 PDT
                     Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) hlellelid Hans Lellelid 2007-10-23 07:16:37 PDT
                         Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached) =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-23 07:17:53 PDT
                             [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-25 18:41:29 PDT
                                 Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-25 18:46:37 PDT
                                     Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-26 05:06:55 PDT
                                         Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-27 19:42:26 PDT
                                             Re: [propel-dev] NestSet 1.3 branch merge hlellelid Hans Lellelid 2007-10-27 20:11:42 PDT
                                                 Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-27 20:37:26 PDT
                                             Re: [propel-dev] NestSet 1.3 branch merge Frank Stelzer <dev at bleedingmoon dot de> Frank Stelzer <dev at bleedingmoon dot de> 2007-10-28 00:29:48 PDT
                                                 Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-28 03:57:10 PDT
                                                     Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-28 04:33:50 PDT
                                                     Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-28 04:39:16 PDT
                                                         Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-10-30 05:44:48 PDT
                                                             Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-11-02 12:18:04 PDT
                                                                 Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-11-02 14:03:03 PDT
                                                                     Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-11-03 03:04:21 PDT
                                                                         Re: [propel-dev] NestSet 1.3 branch merge hlellelid Hans Lellelid 2007-11-03 08:36:24 PDT
                                                                             Re: [propel-dev] NestSet 1.3 branch merge Eric Fredj <eofredj at gmail dot com> Eric Fredj <eofredj at gmail dot com> 2007-11-03 08:49:03 PDT
                                                                                 Re: [propel-dev] NestSet 1.3 branch merge hlellelid Hans Lellelid 2007-11-03 08:50:24 PDT
                                                                         Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-11-03 09:00:40 PDT
Page: of 2 « Previous | Next »
Messages per page: