Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached)

propel
Discussion topic

Back to topic list

Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached)

Reply

Author =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com>
Full name =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com>
Date 2007-10-23 07:17:53 PDT
Message Sure, will do, even though it didn't really change in behavior I
think - AFAI I only fixed it in areas where it was broken before ;)



Am 23.10.2007 um 16:16 schrieb Hans Lellelid:

> Oh, ok. Sounds good.
>
> We do have some nested set documentation on the wiki. If the new
> classes change the way that stuff works, we should update it;
> otherwise,
> I think an email with the changes -- for those using the nested set
> stuff -- would be plenty.
>
> Hans
>
> David Zülke wrote:
>> 'twas just general nested set improvements and bug fixes :) yes, will
>> compile a mail describing the changes.
>>
>>
>> David
>>
>>
>>
>> Am 23.10.2007 um 16:10 schrieb Hans Lellelid:
>>
>>> I'm not sure what changes are in your branch exactly, so I'd just
>>> like
>>> to ask for some documentation for the new features / changes in
>>> behavior
>>> before we release.
>>>
>>> Merge at will, though! I'd like to get another beta out -- and
>>> an RC,
>>> eventually.
>>>
>>> Hans
>>>
>>> David Zülke wrote:
>>>> I'll see if that patch needs merging into my branch. Speaking of
>>>> which,
>>>> I'd like to merge it into the 1.3 branch ASAP. Objections, anyone?
>>>>
>>>>
>>>> David
>>>>
>>>>
>>>>
>>>>
>>>> Am 17.10.2007 um 11:25 schrieb Cameron Brunner:
>>>>
>>>>> Patch applied. Thank you very much for the bug report and patch!
>>>>>
>>>>> On 10/17/07, Felix Gilcher <propel at andersground dot net> wrote:
>>>>>> Hi,
>>>>>>
>>>>>> trying to add this as a ticket results in a 'Potential Spam'
>>>>>> error,
>>>>>> so I'm sending this to the list. I wonder what part matches the
>>>>>> filter ;)
>>>>>>
>>>>>> -----
>>>>>>
>>>>>> the generated BaseFooNestedSetPeer​::deleteNode() retrieves the
>>>>>> node
>>>>>> to delete and then calls delete() on it. However, it passes
>>>>>> (false,
>>>>>> $con) as parameter while Node::delete() only accepts $con and
>>>>>> thus,
>>>>>> the deletion fails.
>>>>>>
>>>>>> A patch to fix this issue is attached.
>>>>>> ------
>>>>>>
>>>>>> regards
>>>>>>
>>>>>> felix
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Cameron Brunner
>>>>>
>>>>> Want a better web browser?
>>>>> http://www.spreadfir​efox.com/?q=affiliat​es&id=182780​&t=1
>>>>>
>>>>> --------------------​--------------------​--------------------​------
>>>>> ---
>>>>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>>>>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>>>>
>>>>>
>>>>
>>>> --------------------​--------------------​--------------------​-------
>>>> --
>>>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>>>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>>>
>>>
>>> --------------------​--------------------​--------------------​--------
>>> -
>>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>>
>>>
>>
>> --------------------​--------------------​--------------------​---------
>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>
>
> --------------------​--------------------​--------------------​---------
> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
> For additional commands, e-mail: dev-help at propel dot tigris dot org
>
>

« Previous message in topic | 7 of 31 | Next message in topic »

Messages

Show all messages in topic

                                                                             Re: [propel-dev] NestSet 1.3 branch merge hlellelid Hans Lellelid 2007-11-03 09:01:47 PDT
                                                                                 Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-11-03 09:40:29 PDT
                                                                                     Re: [propel-dev] NestSet 1.3 branch merge hlellelid Hans Lellelid 2007-11-03 10:06:51 PDT
                                                                                         Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-11-03 13:55:15 PDT
                                                                                             Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-11-03 18:01:52 PDT
                                 Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-27 19:40:11 PDT
Page: of 2 « Previous | Next »
Messages per page: