Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [propel-dev] NestSet 1.3 branch merge

propel
Discussion topic

Back to topic list

Re: [propel-dev] NestSet 1.3 branch merge

Reply

Author Eric Fredj <eofredj at gmail dot com>
Full name Eric Fredj <eofredj at gmail dot com>
Date 2007-10-28 04:33:50 PDT
Message Ok.
I will explain my strategy.
I branch 1.3/ to heltem/ and then I applied all
david-multi_nested_set_tables/ branch changes on heltem/ to make easy
the future. merge

However, I saw many things which were buggy so I fixed some of them.

About sfPropel .... Plugin API, they got our API and added some methods
which made sense to me (insertAsParentOf(), ..) , so I integrated them
and some of ours was not yet implemented or were unuseful so I removed them.
And I added a parent attribute which made sense to me to simplify some
of our methods.

Moreover, I cleaned most of modifiers (static, public, etc.)

If you make a diff between yours and mine, I think changes are really
light and most of them are about 1.3 merge ....

I think the task now is to merge heltem/ and 1.3
Here is attached the patch for that.

My goal was really to make your merge task easy, David.

David Zülke a écrit :
> Okay... but I don't think we should start changing things just so it
> fits symfony more nicely. I don't remember changing method names in my
> branch, and we should keep it like that.
>
>
> David

« Previous message in topic | 16 of 31 | Next message in topic »

Messages

Show all messages in topic

                                                                             Re: [propel-dev] NestSet 1.3 branch merge hlellelid Hans Lellelid 2007-11-03 09:01:47 PDT
                                                                                 Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-11-03 09:40:29 PDT
                                                                                     Re: [propel-dev] NestSet 1.3 branch merge hlellelid Hans Lellelid 2007-11-03 10:06:51 PDT
                                                                                         Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-11-03 13:55:15 PDT
                                                                                             Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-11-03 18:01:52 PDT
                                 Re: [propel-dev] NestSet 1.3 branch merge =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com> 2007-10-27 19:40:11 PDT
Page: of 2 « Previous | Next »
Messages per page: