Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [propel-dev] NestSet 1.3 branch merge

propel
Discussion topic

Hide all messages in topic

All messages in topic

Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached)

Reply

Author hlellelid
Full name Hans Lellelid
Date 2007-10-23 07:16:37 PDT
Message Oh, ok. Sounds good.

We do have some nested set documentation on the wiki. If the new
classes change the way that stuff works, we should update it; otherwise,
I think an email with the changes -- for those using the nested set
stuff -- would be plenty.

Hans

David Zülke wrote:
> 'twas just general nested set improvements and bug fixes :) yes, will
> compile a mail describing the changes.
>
>
> David
>
>
>
> Am 23.10.2007 um 16:10 schrieb Hans Lellelid:
>
>> I'm not sure what changes are in your branch exactly, so I'd just like
>> to ask for some documentation for the new features / changes in behavior
>> before we release.
>>
>> Merge at will, though! I'd like to get another beta out -- and an RC,
>> eventually.
>>
>> Hans
>>
>> David Zülke wrote:
>>> I'll see if that patch needs merging into my branch. Speaking of which,
>>> I'd like to merge it into the 1.3 branch ASAP. Objections, anyone?
>>>
>>>
>>> David
>>>
>>>
>>>
>>>
>>> Am 17.10.2007 um 11:25 schrieb Cameron Brunner:
>>>
>>>> Patch applied. Thank you very much for the bug report and patch!
>>>>
>>>> On 10/17/07, Felix Gilcher <propel at andersground dot net> wrote:
>>>>> Hi,
>>>>>
>>>>> trying to add this as a ticket results in a 'Potential Spam' error,
>>>>> so I'm sending this to the list. I wonder what part matches the
>>>>> filter ;)
>>>>>
>>>>> -----
>>>>>
>>>>> the generated BaseFooNestedSetPeer​::deleteNode() retrieves the node
>>>>> to delete and then calls delete() on it. However, it passes (false,
>>>>> $con) as parameter while Node::delete() only accepts $con and thus,
>>>>> the deletion fails.
>>>>>
>>>>> A patch to fix this issue is attached.
>>>>> ------
>>>>>
>>>>> regards
>>>>>
>>>>> felix
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Cameron Brunner
>>>>
>>>> Want a better web browser?
>>>> http://www.spreadfir​efox.com/?q=affiliat​es&id=182780​&t=1
>>>>
>>>> --------------------​--------------------​--------------------​---------
>>>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>>>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>>>
>>>>
>>>
>>> --------------------​--------------------​--------------------​---------
>>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>>
>>
>> --------------------​--------------------​--------------------​---------
>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>
>>
>
> --------------------​--------------------​--------------------​---------
> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
> For additional commands, e-mail: dev-help at propel dot tigris dot org
>

Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached)

Reply

Author =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com>
Full name =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com>
Date 2007-10-23 07:14:55 PDT
Message 'twas just general nested set improvements and bug fixes :) yes, will
compile a mail describing the changes.


David



Am 23.10.2007 um 16:10 schrieb Hans Lellelid:

> I'm not sure what changes are in your branch exactly, so I'd just like
> to ask for some documentation for the new features / changes in
> behavior
> before we release.
>
> Merge at will, though! I'd like to get another beta out -- and an RC,
> eventually.
>
> Hans
>
> David Zülke wrote:
>> I'll see if that patch needs merging into my branch. Speaking of
>> which,
>> I'd like to merge it into the 1.3 branch ASAP. Objections, anyone?
>>
>>
>> David
>>
>>
>>
>>
>> Am 17.10.2007 um 11:25 schrieb Cameron Brunner:
>>
>>> Patch applied. Thank you very much for the bug report and patch!
>>>
>>> On 10/17/07, Felix Gilcher <propel at andersground dot net> wrote:
>>>> Hi,
>>>>
>>>> trying to add this as a ticket results in a 'Potential Spam' error,
>>>> so I'm sending this to the list. I wonder what part matches the
>>>> filter ;)
>>>>
>>>> -----
>>>>
>>>> the generated BaseFooNestedSetPeer​::deleteNode() retrieves the node
>>>> to delete and then calls delete() on it. However, it passes (false,
>>>> $con) as parameter while Node::delete() only accepts $con and thus,
>>>> the deletion fails.
>>>>
>>>> A patch to fix this issue is attached.
>>>> ------
>>>>
>>>> regards
>>>>
>>>> felix
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Cameron Brunner
>>>
>>> Want a better web browser?
>>> http://www.spreadfir​efox.com/?q=affiliat​es&id=182780​&t=1
>>>
>>> --------------------​--------------------​--------------------​--------
>>> -
>>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>>
>>>
>>
>> --------------------​--------------------​--------------------​---------
>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>
>
> --------------------​--------------------​--------------------​---------
> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
> For additional commands, e-mail: dev-help at propel dot tigris dot org
>
>

Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached)

Reply

Author hlellelid
Full name Hans Lellelid
Date 2007-10-23 07:10:52 PDT
Message I'm not sure what changes are in your branch exactly, so I'd just like
to ask for some documentation for the new features / changes in behavior
 before we release.

Merge at will, though! I'd like to get another beta out -- and an RC,
eventually.

Hans

David Zülke wrote:
> I'll see if that patch needs merging into my branch. Speaking of which,
> I'd like to merge it into the 1.3 branch ASAP. Objections, anyone?
>
>
> David
>
>
>
>
> Am 17.10.2007 um 11:25 schrieb Cameron Brunner:
>
>> Patch applied. Thank you very much for the bug report and patch!
>>
>> On 10/17/07, Felix Gilcher <propel at andersground dot net> wrote:
>>> Hi,
>>>
>>> trying to add this as a ticket results in a 'Potential Spam' error,
>>> so I'm sending this to the list. I wonder what part matches the
>>> filter ;)
>>>
>>> -----
>>>
>>> the generated BaseFooNestedSetPeer​::deleteNode() retrieves the node
>>> to delete and then calls delete() on it. However, it passes (false,
>>> $con) as parameter while Node::delete() only accepts $con and thus,
>>> the deletion fails.
>>>
>>> A patch to fix this issue is attached.
>>> ------
>>>
>>> regards
>>>
>>> felix
>>>
>>>
>>>
>>>
>>
>>
>> --
>> Cameron Brunner
>>
>> Want a better web browser?
>> http://www.spreadfir​efox.com/?q=affiliat​es&id=182780​&t=1
>>
>> --------------------​--------------------​--------------------​---------
>> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
>> For additional commands, e-mail: dev-help at propel dot tigris dot org
>>
>>
>
> --------------------​--------------------​--------------------​---------
> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
> For additional commands, e-mail: dev-help at propel dot tigris dot org
>

Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached)

Reply

Author =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com>
Full name =?ISO-8859-1?Q?David_Z=FClke?= <dz at bitxtender dot com>
Date 2007-10-23 07:09:31 PDT
Message I'll see if that patch needs merging into my branch. Speaking of
which, I'd like to merge it into the 1.3 branch ASAP. Objections,
anyone?


David




Am 17.10.2007 um 11:25 schrieb Cameron Brunner:

> Patch applied. Thank you very much for the bug report and patch!
>
> On 10/17/07, Felix Gilcher <propel at andersground dot net> wrote:
>> Hi,
>>
>> trying to add this as a ticket results in a 'Potential Spam' error,
>> so I'm sending this to the list. I wonder what part matches the
>> filter ;)
>>
>> -----
>>
>> the generated BaseFooNestedSetPeer​::deleteNode() retrieves the node
>> to delete and then calls delete() on it. However, it passes (false,
>> $con) as parameter while Node::delete() only accepts $con and thus,
>> the deletion fails.
>>
>> A patch to fix this issue is attached.
>> ------
>>
>> regards
>>
>> felix
>>
>>
>>
>>
>
>
> --
> Cameron Brunner
>
> Want a better web browser?
> http://www.spreadfir​efox.com/?q=affiliat​es&id=182780​&t=1
>
> --------------------​--------------------​--------------------​---------
> To unsubscribe, e-mail: dev-unsubscribe@prop​el.tigris.org
> For additional commands, e-mail: dev-help at propel dot tigris dot org
>
>

Re: [propel-dev] PHP5NestedSetPeerBuilder slightly broken (PATCH attached)

Reply

Author Cameron Brunner <cameron dot brunner at gmail dot com>
Full name Cameron Brunner <cameron dot brunner at gmail dot com>
Date 2007-10-17 02:25:32 PDT
Message Patch applied. Thank you very much for the bug report and patch!

On 10/17/07, Felix Gilcher <propel at andersground dot net> wrote:
> Hi,
>
> trying to add this as a ticket results in a 'Potential Spam' error,
> so I'm sending this to the list. I wonder what part matches the
> filter ;)
>
> -----
>
> the generated BaseFooNestedSetPeer​::deleteNode() retrieves the node
> to delete and then calls delete() on it. However, it passes (false,
> $con) as parameter while Node::delete() only accepts $con and thus,
> the deletion fails.
>
> A patch to fix this issue is attached.
> ------
>
> regards
>
> felix
>
>
>
>


--
Cameron Brunner

Want a better web browser?
http://www.spreadfir​efox.com/?q=affiliat​es&id=182780​&t=1

PHP5NestedSetPeerBuilder slightly broken (PATCH attached)

Reply

Author Felix Gilcher <propel at andersground dot net>
Full name Felix Gilcher <propel at andersground dot net>
Date 2007-10-17 01:38:33 PDT
Message Hi,

trying to add this as a ticket results in a 'Potential Spam' error,
so I'm sending this to the list. I wonder what part matches the
filter ;)

-----

the generated BaseFooNestedSetPeer​::deleteNode() retrieves the node
to delete and then calls delete() on it. However, it passes (false,
$con) as parameter while Node::delete() only accepts $con and thus,
the deletion fails.

A patch to fix this issue is attached.
------

regards

felix
Attachments
Page: of 2 « Previous | Next »
Messages per page: